PMD Results

The following document contains the results of PMD 4.2.5.

Files

net/sf/sshapi/AbstractProvider.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method56
Use explicit scoping instead of the default package private level114 - 120

net/sf/sshapi/DefaultChannelData.java

ViolationLine
Use explicit scoping instead of the default package private level6
Use explicit scoping instead of the default package private level7
Use explicit scoping instead of the default package private level8
Use explicit scoping instead of the default package private level9
Use explicit scoping instead of the default package private level10

net/sf/sshapi/DefaultProviderFactory.java

ViolationLine
Avoid unnecessary constructors - the compiler will generate these for you64 - 65
Found 'DU'-anomaly for variable 'providers' (lines '86'-'97').86 - 97
A method should have only one exit point, and that should be the last statement in the method328
A method should have only one exit point, and that should be the last statement in the method345
A method should have only one exit point, and that should be the last statement in the method353

net/sf/sshapi/Logger.java

ViolationLine
Avoid modifiers which are implied by the context35 - 78

net/sf/sshapi/SshChannel.java

ViolationLine
Avoid modifiers which are implied by the context12 - 52

net/sf/sshapi/SshDataListener.java

ViolationLine
Avoid modifiers which are implied by the context39
Avoid modifiers which are implied by the context45
Avoid modifiers which are implied by the context52

net/sf/sshapi/auth/SshAuthenticator.java

ViolationLine
Avoid modifiers which are implied by the context40

net/sf/sshapi/forwarding/SshPortForward.java

ViolationLine
Avoid modifiers which are implied by the context42
Avoid modifiers which are implied by the context47
Avoid modifiers which are implied by the context52

net/sf/sshapi/forwarding/SshPortForwardListener.java

ViolationLine
Avoid modifiers which are implied by the context37
Avoid modifiers which are implied by the context45

net/sf/sshapi/hostkeys/AbstractHostKey.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method35

net/sf/sshapi/hostkeys/AbstractHostKeyManager.java

ViolationLine
These nested if statements could be combined62 - 74
Avoid empty catch blocks72 - 73

net/sf/sshapi/hostkeys/SshHostKeyValidator.java

ViolationLine
Avoid modifiers which are implied by the context39
Avoid modifiers which are implied by the context45
Avoid modifiers which are implied by the context53

net/sf/sshapi/identity/SshPrivateKeyFile.java

ViolationLine
Avoid modifiers which are implied by the context40
Avoid modifiers which are implied by the context45
Avoid modifiers which are implied by the context50
Avoid modifiers which are implied by the context55
Avoid modifiers which are implied by the context60
Avoid modifiers which are implied by the context64
Avoid modifiers which are implied by the context69
Avoid modifiers which are implied by the context74
Avoid modifiers which are implied by the context79
Avoid modifiers which are implied by the context83

net/sf/sshapi/identity/SshPublicKeyFile.java

ViolationLine
Avoid modifiers which are implied by the context41
Avoid modifiers which are implied by the context46
Avoid modifiers which are implied by the context51
Avoid modifiers which are implied by the context56

net/sf/sshapi/sftp/AbstractSftpClient.java

ViolationLine
Found 'DU'-anomaly for variable 'path' (lines '52'-'69').52 - 69
Avoid empty catch blocks79 - 80
Avoid empty catch blocks97 - 98

net/sf/sshapi/util/BatchHostKeyValidator.java

ViolationLine
Found 'DU'-anomaly for variable 'type' (lines '57'-'80').57 - 80
A method should have only one exit point, and that should be the last statement in the method63
A method should have only one exit point, and that should be the last statement in the method76

net/sf/sshapi/util/ConsoleHostKeyValidator.java

ViolationLine
Found 'DU'-anomaly for variable 'type' (lines '61'-'94').61 - 94
A method should have only one exit point, and that should be the last statement in the method67
A method should have only one exit point, and that should be the last statement in the method80

net/sf/sshapi/util/ConsoleKeyboardInteractiveAuthenticator.java

ViolationLine
Found 'DD'-anomaly for variable 'answers' (lines '44'-'46').44 - 46
Found 'DD'-anomaly for variable 'answers' (lines '46'-'46').46

net/sf/sshapi/util/ConsolePasswordAuthenticator.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.38

net/sf/sshapi/util/Util.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method99
A method should have only one exit point, and that should be the last statement in the method155
Found 'DD'-anomaly for variable 'arr' (lines '189'-'191').189 - 191
Found 'DD'-anomaly for variable 'arr' (lines '191'-'191').191
Avoid assignments in operands207
Found 'DU'-anomaly for variable 'r' (lines '207'-'211').207 - 211
Found 'DD'-anomaly for variable 'dir' (lines '256'-'261').256 - 261
Found 'DU'-anomaly for variable 'file' (lines '258'-'267').258 - 267
A method should have only one exit point, and that should be the last statement in the method278
A method should have only one exit point, and that should be the last statement in the method284
Found 'DD'-anomaly for variable 'dir' (lines '321'-'324').321 - 324
A method should have only one exit point, and that should be the last statement in the method372

net/sf/sshapi/util/XAuthorityFile.java

ViolationLine
Do not use the short type65
Do not use the short type66
These nested if statements could be combined94 - 97
These nested if statements could be combined102 - 105

net/sf/sshapi/util/XDetails.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.77