PMD Results

The following document contains the results of PMD 4.2.5.

Files

net/sf/sshapi/impl/maverick/MaverickHostKeyManager.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method180

net/sf/sshapi/impl/maverick/MaverickIdentityManager.java

ViolationLine
Found 'DD'-anomaly for variable 'typeNo' (lines '72'-'74').72 - 74
Found 'DD'-anomaly for variable 'typeNo' (lines '72'-'76').72 - 76
Found 'DD'-anomaly for variable 'typeNo' (lines '72'-'78').72 - 78
Found 'DU'-anomaly for variable 'typeNo' (lines '72'-'89').72 - 89
A method should have only one exit point, and that should be the last statement in the method111
A method should have only one exit point, and that should be the last statement in the method113
Found 'DU'-anomaly for variable 'pk' (lines '138'-'160').138 - 160
Found 'DU'-anomaly for variable 'publicKeyFile' (lines '155'-'160').155 - 160
A method should have only one exit point, and that should be the last statement in the method226
A method should have only one exit point, and that should be the last statement in the method228
A method should have only one exit point, and that should be the last statement in the method242
A method should have only one exit point, and that should be the last statement in the method244
A method should have only one exit point, and that should be the last statement in the method246
A method should have only one exit point, and that should be the last statement in the method248
A method should have only one exit point, and that should be the last statement in the method250

net/sf/sshapi/impl/maverick/MaverickPublicKeySubsystem.java

ViolationLine
It is a good practice to call super() in a constructor48 - 50

net/sf/sshapi/impl/maverick/MaverickSCPClient.java

ViolationLine
It is a good practice to call super() in a constructor20 - 22

net/sf/sshapi/impl/maverick/MaverickSftpClient.java

ViolationLine
It is a good practice to call super() in a constructor50 - 53
Found 'DD'-anomaly for variable 'files' (lines '66'-'68').66 - 68
Found 'DD'-anomaly for variable 'files' (lines '68'-'68').68
Use explicit scoping instead of the default package private level88 - 90
Use explicit scoping instead of the default package private level183 - 189
A method should have only one exit point, and that should be the last statement in the method185
Avoid empty catch blocks186 - 187
Use explicit scoping instead of the default package private level191 - 207
A method should have only one exit point, and that should be the last statement in the method193
A method should have only one exit point, and that should be the last statement in the method195
A method should have only one exit point, and that should be the last statement in the method197
A method should have only one exit point, and that should be the last statement in the method199
A method should have only one exit point, and that should be the last statement in the method201
A method should have only one exit point, and that should be the last statement in the method203

net/sf/sshapi/impl/maverick/MaverickSshClient.java

ViolationLine
Use explicit scoping instead of the default package private level116
A method should have only one exit point, and that should be the last statement in the method204
A method should have only one exit point, and that should be the last statement in the method206
It is a good practice to call super() in a constructor230 - 233
Found 'DD'-anomaly for variable 'send' (lines '255'-'259').255 - 259
Found 'DD'-anomaly for variable 'send' (lines '259'-'259').259
Found 'DU'-anomaly for variable 'msc' (lines '342'-'360').342 - 360
Found 'DU'-anomaly for variable 'msc' (lines '342'-'360').342 - 360
Found 'DU'-anomaly for variable 'msc' (lines '342'-'360').342 - 360
Found 'DU'-anomaly for variable 'ssh2Channel' (lines '343'-'360').343 - 360
Found 'DU'-anomaly for variable 'ssh2Channel' (lines '343'-'360').343 - 360
Found 'DU'-anomaly for variable 'ssh2Channel' (lines '343'-'360').343 - 360
Assigning an Object to null is a code smell. Consider refactoring.375
Found 'DU'-anomaly for variable 'proxyServer' (lines '376'-'425').376 - 425
A method should have only one exit point, and that should be the last statement in the method437
Found 'DU'-anomaly for variable 'authenticatorMap' (lines '451'-'495').451 - 495
A method should have only one exit point, and that should be the last statement in the method492
A method should have only one exit point, and that should be the last statement in the method500 - 506
Found 'DU'-anomaly for variable 'pkf' (lines '510'-'588').510 - 588
Found 'DU'-anomaly for variable 'pkf' (lines '510'-'588').510 - 588
Found 'DU'-anomaly for variable 'pkf' (lines '510'-'588').510 - 588
Found 'DU'-anomaly for variable 'pkf' (lines '510'-'588').510 - 588
Found 'DU'-anomaly for variable 'pair' (lines '511'-'588').511 - 588
Found 'DD'-anomaly for variable 'pair' (lines '511'-'519').511 - 519
Found 'DD'-anomaly for variable 'pair' (lines '511'-'527').511 - 527
Found 'DU'-anomaly for variable 'pair' (lines '511'-'588').511 - 588
Found 'DD'-anomaly for variable 'pair' (lines '511'-'519').511 - 519
Found 'DD'-anomaly for variable 'pair' (lines '511'-'527').511 - 527
Found 'DU'-anomaly for variable 'pair' (lines '511'-'588').511 - 588
Found 'DD'-anomaly for variable 'pair' (lines '511'-'519').511 - 519
Found 'DD'-anomaly for variable 'pair' (lines '511'-'527').511 - 527
Found 'DU'-anomaly for variable 'pair' (lines '511'-'588').511 - 588
Found 'DD'-anomaly for variable 'pair' (lines '511'-'519').511 - 519
Found 'DD'-anomaly for variable 'pair' (lines '511'-'527').511 - 527
Found 'DU'-anomaly for variable 'pair' (lines '519'-'588').519 - 588
Found 'DD'-anomaly for variable 'pair' (lines '519'-'519').519
Found 'DD'-anomaly for variable 'pair' (lines '519'-'527').519 - 527
Found 'DU'-anomaly for variable 'pair' (lines '519'-'588').519 - 588
Found 'DD'-anomaly for variable 'pair' (lines '519'-'519').519
Found 'DD'-anomaly for variable 'pair' (lines '519'-'527').519 - 527
Found 'DU'-anomaly for variable 'pair' (lines '519'-'588').519 - 588
Found 'DD'-anomaly for variable 'pair' (lines '519'-'519').519
Found 'DD'-anomaly for variable 'pair' (lines '519'-'527').519 - 527
Found 'DU'-anomaly for variable 'pair' (lines '519'-'588').519 - 588
Found 'DD'-anomaly for variable 'pair' (lines '519'-'519').519
Found 'DD'-anomaly for variable 'pair' (lines '519'-'527').519 - 527
Found 'DU'-anomaly for variable 'pair' (lines '527'-'588').527 - 588
Found 'DU'-anomaly for variable 'pair' (lines '527'-'588').527 - 588
Found 'DU'-anomaly for variable 'pair' (lines '527'-'588').527 - 588
Found 'DU'-anomaly for variable 'pair' (lines '527'-'588').527 - 588
A method should have only one exit point, and that should be the last statement in the method537
A method should have only one exit point, and that should be the last statement in the method561
Found 'DD'-anomaly for variable 'prompt' (lines '568'-'571').568 - 571
Found 'DD'-anomaly for variable 'prompt' (lines '568'-'571').568 - 571
Found 'DD'-anomaly for variable 'prompt' (lines '568'-'571').568 - 571
Found 'DD'-anomaly for variable 'prompt' (lines '568'-'571').568 - 571
Found 'DD'-anomaly for variable 'echo' (lines '569'-'572').569 - 572
Found 'DD'-anomaly for variable 'echo' (lines '569'-'572').569 - 572
Found 'DD'-anomaly for variable 'echo' (lines '569'-'572').569 - 572
Found 'DD'-anomaly for variable 'echo' (lines '569'-'572').569 - 572
Found 'DD'-anomaly for variable 'prompt' (lines '571'-'571').571
Found 'DD'-anomaly for variable 'prompt' (lines '571'-'571').571
Found 'DD'-anomaly for variable 'prompt' (lines '571'-'571').571
Found 'DD'-anomaly for variable 'prompt' (lines '571'-'571').571
Found 'DD'-anomaly for variable 'echo' (lines '572'-'572').572
Found 'DD'-anomaly for variable 'echo' (lines '572'-'572').572
Found 'DD'-anomaly for variable 'echo' (lines '572'-'572').572
Found 'DD'-anomaly for variable 'echo' (lines '572'-'572').572
Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !652
Found 'DU'-anomaly for variable 'fLocalAddress' (lines '652'-'671').652 - 671
Found 'DU'-anomaly for variable 'fLocalAddress' (lines '652'-'671').652 - 671
Found 'DU'-anomaly for variable 'fLocalAddress' (lines '652'-'671').652 - 671
Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !676
Found 'DU'-anomaly for variable 'fRemoteHost' (lines '676'-'695').676 - 695
Found 'DU'-anomaly for variable 'fRemoteHost' (lines '676'-'695').676 - 695
Found 'DU'-anomaly for variable 'fRemoteHost' (lines '676'-'695').676 - 695
It is a good practice to call super() in a constructor738 - 740
Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !792
Assigning an Object to null is a code smell. Consider refactoring.809
Found 'DU'-anomaly for variable 'status' (lines '859'-'895').859 - 895
Found 'DU'-anomaly for variable 'status' (lines '859'-'895').859 - 895
Found 'DU'-anomaly for variable 'status' (lines '859'-'895').859 - 895
Found 'DU'-anomaly for variable 'status' (lines '859'-'895').859 - 895
Found 'DU'-anomaly for variable 'status' (lines '859'-'895').859 - 895
A method should have only one exit point, and that should be the last statement in the method885
A method should have only one exit point, and that should be the last statement in the method892
Found 'DU'-anomaly for variable 'sshapiType' (lines '905'-'917').905 - 917
Found 'DU'-anomaly for variable 'sshapiType' (lines '924'-'935').924 - 935
Found 'DD'-anomaly for variable 'sshapiType' (lines '938'-'940').938 - 940
Found 'DD'-anomaly for variable 'sshapiType' (lines '938'-'942').938 - 942
It is a good practice to call super() in a constructor974 - 1001

net/sf/sshapi/impl/maverick/MaverickSshProvider.java

ViolationLine
Found 'DU'-anomaly for variable 'ciphers' (lines '141'-'156').141 - 156
Found 'DU'-anomaly for variable 'ssh2Context' (lines '145'-'156').145 - 156

net/sf/sshapi/impl/maverick/MaverickSshStreamChannel.java

ViolationLine
It is a good practice to call super() in a constructor43 - 45